search

pivotal / blog

Pivotal Engineering Blog
https://engineering.pivotal.io/
40 stars 47 forks source link

Update the article on Spring + mock SSO #264

Open tomakehurst opened 4 years ago

tomakehurst commented 4 years ago

I'm the creator of WireMock and I've been doing some work on making it easier to mock OAuth2 flows recently.

I've developed a couple of things I think would be useful to your readers:

1) A way of mocking an OAuth2 flow in WireMock without needing to write a custom transformer, which is simpler and can be used for parallel/load testing (since there's no stored state involved).

2) A free, hosted OAuth2 / OpenID Connect mock you can just point your app to.

So, I'd like to propose an update to https://github.com/pivotal/blog/blob/master/content/post/faking_oauth_sso.md showing the simplified WireMock approach, and linking out to the hosted OAuth mock.

Is this something you'd be willing to merge? If so, I'm happy to write the update and submit a PR.

theextremeprogrammer commented 4 years ago

Hi Tom! My name is Derek and I'm an engineer with Pivotal Labs (now VMware).

First of all - thanks for opening up this issue! But more-so, thank you for all of your work with WireMock! I know that I've used it myself and many of of us at Pivotal have used it and really appreciate the great efforts that has gone into it (and likely we don't often enough take the time to say 'thanks' as often as we should!).

The enhancements that you've made to WireMock sound like great additions and personally I'd love to try them out. Making an update to the existing blog post sounds like a good idea, but I'm not sure I have the authority to give the green light. Therefore I went ahead and sent an email to the original author @brian-watkins to make sure he's in the loop as he's still with us and have him take a look.

Thanks again for taking the time to contact us about this!

brian-watkins commented 4 years ago

Hi Tom! Yes, I'd be happy for you to submit an update to the article. The changes you describe sound really great!

(And let me second Derek's comment -- Thanks for all your work on WireMock -- we use it all the time!)

tomakehurst commented 4 years ago

Hi @derekleerock , Hi @brian-watkins, thanks for the kind words!

If you're interested, the hosted OAuth2 mock is here: https://www.mocklab.io/oauth2/. The demo app is Spring Boot and the source code for it is linked so should hopefully be a useful resource.

Also thanks for the offer to accept an update to the blog. I'll send a PR your way early next week.