Heavily update tcpdump story

pivotal / cf-onboarding

Iterating on Onboarding Week with lightning speed and cunning

MIT License

36 stars 69 forks source link

Heavily update tcpdump story #264

Closed ameowlia closed 5 years ago

ameowlia commented 5 years ago

Complete change the tcpdump story. Now on c2c.

Problems with the old story:

It needs some work
Had more people run through it, and they had problems
I don't want to confuse people more with a bad story
Lost the source code for the pingaling app

Better new story:

Now related to c2c (where I use the tool the most in real debugging situations)
More help provided to figure out tcpdump
Less throwing people in the deep end

cc @christianang

bwinter commented 5 years ago

Wow full rewrite!

🚧 🚧 🚧 🚧 🚜 👷‍♀️ 👷 🏗

ameowlia commented 5 years ago

Thanks for your thorough review @bwinter. I will update soon. ⭐️

edited to add: updating done!

bwinter commented 5 years ago

(I'll let you do the honors of merging it if you like!)

ameowlia commented 5 years ago

@bwinter I don't have permissions. You will need to merge. Thanks!

bwinter commented 5 years ago

Oh no! I hadn't realized :(.

Hmmmm, I don't fully understand all the permissioning around this repo. It kind of seems like half the pleasure of making a PR is merging it! (I'll see if I can get you that permission real quick, if it doesn't seem easy I'll merge it just to get your changes on master then deal with alternatives down the road.)

bwinter commented 5 years ago

I didn't see any obvious ways to allow merge for contributors like your self (I am not a github ninja); so, I just went ahead and added you as a team member who can write. (your helping so much we should just call you what you are :D).

Does it let you merge now?

ameowlia commented 5 years ago

success! Thanks @bwinter ❄️ !