Adds missing param to cleanup, clarifies bosh deploy

genehynson commented 4 years ago

SF CF Onboarding 2019 Feedback

Adds the missing required parameter to bbl destroy like --gcp-service-account-key=service-account.key.json
Instructs to use latest bosh manifest when re-deploying rather than the original cf-deployment.yml manifest. If you don't do this, you end up in a situation where some of the previous network policy changes are reverted. It also is really confusing when bosh prints out the manifest changes and it's way more than the intended change (i.e. instances: 3).

genehynson commented 4 years ago

@suprajanarasimhan @bwinter Check this out and let us know what you think! Thanks!

bwinter commented 4 years ago

Thanks a bunch for creating this PR, it is much appreciated!

I had one question but other wise this LGTM!