pivotal / docs-tas-adapter

2 stars 5 forks source link

Fix default value for kubernetes version #87

Closed akrishna90 closed 1 year ago

akrishna90 commented 1 year ago

Value needs to contain only digits and . for kubenetes_version key.

We should cheery pick this merge into release/1.1 branch

cf-gitbot commented 1 year ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

HenryBorys commented 1 year ago

I’ll do the cherry picking, but please do let me know what versions the pr applies to. Thanks, Ajayan


Sent from Workspace ONE Boxerhttps://whatisworkspaceone.com/boxer

On March 28, 2023 at 9:04:18 AM PDT, Tim Downey @.***> wrote:

@tcdowney approved this pull request.

LGTM

@HenryBoryshttps://github.com/HenryBorys do you typically handle cherry-picking to release branches or is that something we should do?

— Reply to this email directly, view it on GitHubhttps://github.com/pivotal/docs-tas-adapter/pull/87#pullrequestreview-1361454099, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWEGHTTBMI6IXDLRHQ7WWDDW6MDX7ANCNFSM6AAAAAAWJQONY4. You are receiving this because you were mentioned.Message ID: @.***>

tcdowney commented 1 year ago

I’ll do the cherry picking, but please do let me know what versions the pr applies to. Thanks, Ajayan

I think this belongs on just the main and release/1.1 branches.

HenryBorys commented 1 year ago

Thanks!


Sent from Workspace ONE Boxerhttps://whatisworkspaceone.com/boxer

On March 28, 2023 at 10:43:22 AM PDT, Tim Downey @.***> wrote:

I’ll do the cherry picking, but please do let me know what versions the pr applies to. Thanks, Ajayan

I think this belongs on just the main and release/1.1 branches.

— Reply to this email directly, view it on GitHubhttps://github.com/pivotal/docs-tas-adapter/pull/87#issuecomment-1487349275, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWEGHTQMT55ICVTEJ5TVFOTW6MPLNANCNFSM6AAAAAAWJQONY4. You are receiving this because you were mentioned.Message ID: @.***>