Fix Initial number of replicas

pivotal / skenario

A simulator toolkit for Knative

Apache License 2.0

30 stars 10 forks source link

Fix Initial number of replicas #109

Closed juliababkina closed 4 years ago

juliababkina commented 4 years ago

Currently, Skenario starts simulation from one replica. It's exactly what we need in HPA. But in order to introduce VPA, it's essential to to set the number of replicas themselves. Also, this PR fixes the case, when we have only one replica and see not a single one in UI.

josephburnett commented 4 years ago

I see now there is a replica at the outset. However, something still seems to be wrong. I'm not seeing expected scale-out behavior. Even with high utilization, we remain at 1 replica.

juliababkina commented 4 years ago

This is very interesting because I can't reproduce it. Screenshot 2020-08-25 at 3 15 05 PM - Display 2

josephburnett commented 4 years ago

I'll go ahead and merge this since it does create an initial replica, which is better than the current state. But I'll follow up to figure out why the difference between our results.