pivotal / workstation-setup

Scripts to automatically set up a machine for development the "Tanzu Labs" way
https://github.com/pivotal/workstation-setup
MIT License
328 stars 247 forks source link

Move virtualbox to its own command line option #200

Closed dirkjot closed 6 years ago

dirkjot commented 6 years ago
nertzy commented 6 years ago

I'm OK with this. What do you think @professor?

professor commented 6 years ago

My intuition is to remove virtualbox from workstation-setup, however, I'm fine with accepting this change.

dirkjot commented 6 years ago

I think we should one day collect metrics on which options are used. I was reluctant to remove the virtualbox functionality without any insight into who may be using it.

On Wed, Apr 11, 2018 at 5:21 PM, Todd Sedano notifications@github.com wrote:

My intuition is to remove virtualbox from workstation-setup, however, I'm fine with accepting this change.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pivotal/workstation-setup/pull/200#issuecomment-380635560, or mute the thread https://github.com/notifications/unsubscribe-auth/AAy5NVTLo6Pw9w9de2tz9VVq2TaUtsM6ks5tnp4QgaJpZM4TOxS0 .

-- Dirk P. Janssen

nertzy commented 6 years ago

Yeah it’s very easy to figure out how to install VirtualBox another way and it’s not typical to most of our workflows anymore, especially with Docker being more broadly used.

professor commented 6 years ago

I'd prefer to keep the options to programming languages + docker. Having docker in that list feels odd. Maybe docker should be pulled into standard install for all installations.

I've added https://github.com/pivotal/workstation-setup/pull/201

professor commented 6 years ago

Here's another idea. First we remove virtualbox. If anyone complains, then we can look for this pull request to bring it back in. Thought?

nertzy commented 6 years ago

Yes, let’s remove it.

professor commented 6 years ago

We successfully removed virtualbox from workstation-setup.