pivotal / workstation-setup

Scripts to automatically set up a machine for development the "Tanzu Labs" way
https://github.com/pivotal/workstation-setup
MIT License
328 stars 247 forks source link

Make setting up git-hooks-core idempotent #205

Closed Kehrlann closed 6 years ago

Kehrlann commented 6 years ago

Running the setup multiple times was failing on High Sierra. First run was fine, subsequent runs are failing due to $HOME/workspace/git-hooks-core being present already. Also, we were littering the git config with multiple core.hookspath values pointing to that directory.

Changed the script scripts/common/git.shso that it :

Note: one assumption we made is that you will not be changing the git-hooks-core repo locally ; this is why we allow a git pull -r on it.

nertzy commented 6 years ago

I will merge this once I regain my committer access.

onlyawave commented 6 years ago

Merged