pivotal / workstation-setup

Scripts to automatically set up a machine for development the "Tanzu Labs" way
https://github.com/pivotal/workstation-setup
MIT License
328 stars 247 forks source link

Add wget #233

Closed andrebrowne closed 6 years ago

professor commented 6 years ago

Hi @andrebrowne,

Looks like your team has made some nice customizations to workstation-setup. Is it your intention to be contributing these back to this repo, or to your team's version of it.

While I like to be inclusive of changes, I'd like for this repo to not become a "junk drawer" of many different tools that only 1 team might be using. I ask myself, "Would I want this tool on everyone's workstation?" If yes, I include it. If no, I let my team add it on. If it is somewhere in the middle, then it depends.

Let me know what you think

andrebrowne commented 6 years ago

@professor I had the same thought while working on this.

I agree that we should keep this repo clean and only include tools that are useful for all.

With that in mind, I would say wget and meld are candidates for workstation-setup. The others can stay on the fork.

Let me know if you agree and I will make the necessary changes.

nertzy commented 6 years ago

I agree about wget (I have manually installed it many different times across different teams), but I'm not directly familiar with meld yet.

andrebrowne commented 6 years ago

MELD: http://meldmerge.org/

meld is a pretty awesome file and directory compare tool and can be tied into the git mergetool command pretty easily.

That-being-said it isn't a widely or commonly known application so I can understand the reluctance to add it to the repo.