search

pivotal / workstation-setup

Scripts to automatically set up a machine for development the "Tanzu Labs" way
https://github.com/pivotal/workstation-setup
MIT License
328 stars 247 forks source link

Install fails on `brew install vim --with-override-system-vi` #247

Closed rgravina closed 5 years ago

rgravina commented 5 years ago

I ran ./setup.sh java, and install terminated early. The last output before termination was:

Summary
🍺  /usr/local/Cellar/git-author/1.0.2: 6 files, 6.8KB, built in 4 seconds
Usage: brew install [options] formula

Install formula.
[ ... usage of formula ... ]
Error: invalid option: --with-override-system-vi

My guess would be that something fails in workstation-setup/scripts/common/git.sh based on this output:

brew install git-author
# Get latest version of vim
brew install vim --with-override-system-vi

Removing the --with-override-system-vi allows setup to continue.

I have a freshly installed Mojave installation. Re-running ./setup.sh java with the flag commented out allows it to continue. I'm not sure if this means the system vim was not overridden. which vim returns a symlink to /usr/local/Cellar/vim/8.1.0850/bin/vim so I'm guessing this is OK.

textbook commented 5 years ago

Looks like options are being removed from all core formulae, relevant PR for the vim formula: https://github.com/Homebrew/homebrew-core/pull/34421

rgravina commented 5 years ago

@textbook Thanks for the update/reference! Guess we just remove the option then?

nertzy commented 5 years ago

Fixed by 8e307518ce696d43df26f03914dd0e48e5895999