pivotal / workstation-setup

Scripts to automatically set up a machine for development the "Tanzu Labs" way
https://github.com/pivotal/workstation-setup
MIT License
325 stars 240 forks source link

Adding interactive setup menu and updating readme #300

Open xtreme-steve-elliott opened 3 years ago

xtreme-steve-elliott commented 3 years ago

If you run ./setup.sh without any arguments, it will prompt you as to whether you want to install any opt-ins, and if you respond affirmatively, then it will present you with the list of opt-ins, as read from the file names in the opt-in directory. You can provide it the numbers of the items you want to include, and it will install those.

joemoore commented 2 years ago

This is a very interesting pull request and seems to address the following concerns:

These might be real concerns. It is true that telling people to look in the opt-ins dir is kinda cheesy.

That said, I am inclined to reject this PR and I want to explain why in detail.

Question: is there a way to address these concerns already? Yes, we can provide better documentation or add simpler features.

Question: what are the rewards vs. risks tradeoffs? The reward: a more pleasant and informative experience for some. The risks:

In summary, I feel the features added in this PR are too fancy and logic-filled for the keep-it-simple ethos of this tool. Colors, numbers, formatting, prompts, parsing -- it's just too much.

Alternatives and Suggestions

I welcome your thoughts.

joemoore commented 2 years ago

Checking for input again.

xtreme-steve-elliott commented 2 years ago

I mean, sure, I could add ./setup.sh --list, though I would probably just close this PR and make an entirely different branch at that point, since the majority of the code isn't the part that actually retrieves the list of available opt-ins, and it wouldn't be interactive after scoping it down to that.