search

pivotx / PivotX

GNU General Public License v2.0
4 stars 5 forks source link

File picker sort in order newest first #20

Closed bcmans closed 1 year ago

hansfn commented 1 year ago

Thx for the contribution. I appreciate even if I will close the PR without merging it ;-)

  1. It seems your PR contains one unrelated change: The addition of %date% replacement to next and previous entry tags. The normal procedure is to create one branch for each change and make separate PRs. Maybe it wasn't intentional to include this change?
  2. I actually prefer the sort order to be alphabetical. If you want it to be newest first, that should be activated by an option.

PS! We have stopped using getDefault. If you create another PR for the date thing, it should be

$dateformat = $params['dateformat'] ?? "%dayname% %day% %monthname% %year%";