search

pivvenit / acf-composer-bridge

Provides a static composer repository that references all Advanced Custom Fields Pro versions
MIT License
47 stars 8 forks source link

Update ACF Pro download endpoint #5

Closed nlemoine closed 4 years ago

nlemoine commented 4 years ago

Hi @pivvenci

ACF download URL recently changed.

nlemoine commented 4 years ago

@schliflo I fixed the typo ;)

Qrious commented 4 years ago

I'll update this, this also requires an update of our installer. I'll release the new version as well

nlemoine commented 4 years ago

I didn't notice download URL was also somewhere in installer. Thanks!

Qrious commented 4 years ago

For now ACF's API is still backwards compatible :). I'm still giving this some thought, to make sure we have the best upgrade path. I think it is important that I update the installer in a backwards compatible manner.

I'll look further at this later today.

Qrious commented 4 years ago

I've released a new version (2.3) of the installer. However I think we should only use the new download link for releases >= 5.8.8, and then also require ^2.3 of the installer for these newer versions. Otherwise current versions break with the old installers.

Qrious commented 4 years ago

I've added these changes. What do you think, does this break compatibility with any of your projects (I don't think it should)?

nlemoine commented 4 years ago

For now ACF's API is still backwards compatible :)

I just checked, it is ok now but I actually made this PR because I had a 404 on the old download link a few days ago.

What do you think, does this break compatibility with any of your projects (I don't think it should)?

I think you shouldn't bother to target different URLs, the new endpoint works fine with every ACF version ;)

Qrious commented 4 years ago

That does however break backwards compatibility with people that have the old versions in their lock file, together with the old installers, so i've decided to support the new URL's for the latest release and upwards (as does ACF-PRO when used without composer).

nlemoine commented 4 years ago

I didn't catch the installer issue. Great job. Thanks for merging this!