search

pivvenit / acf-composer-bridge

Provides a static composer repository that references all Advanced Custom Fields Pro versions
MIT License
47 stars 8 forks source link

Blocks and compatibility with WPML #7

Closed vyskoczilova closed 4 years ago

vyskoczilova commented 4 years ago

Hi,

I've built some blocks for a theme and used ACF composer integration for doing that. But I had to install a plugin version to make it work with WPML & translatable options 🙁 Could you fix that?

The "Translation preferences - What to do with the field's value when the post/page is going to be translated" radio list is not displayed.

Maybe I'm just missing something, but it doesn't work :( and your help is appreciated

My composer.json

{
    "repositories": [
        {
            "type": "composer",
            "url": "https://pivvenit.github.io/acf-composer-bridge/composer/v3/library/"
        }
    ],
    "require": {
        "advanced-custom-fields/advanced-custom-fields-pro": "^5.8",
    }
}
Qrious commented 4 years ago

From your description it seems to me that this does not seem to be an issue with our bridge, since our bridge/plugin only provides a way to install ACF via composer.

But I had to install a plugin version to make it work with WPML & translatable options

Do you mean by this that you had to use a specific version of ACF to make it work?

I'll try to point you in the right direction if this is not a bug in our installer/bridge

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

vyskoczilova commented 4 years ago

Hi @Qrious, sorry for the late reply, I've missed the notification from Github :(

I load the ACF from Composer and somehow WPML plugin is not compatible with it. But maybe this is more WPML bug than yours. I'll try to check how they check for ACF installed, maybe they are trying to find it within plugins, not by class or something...

Qrious commented 4 years ago

I'll try to check how they check for ACF installed, maybe they are trying to find it within plugins, not by class or something...

That seems like a very plausible explanation for the problem. I've seen these types of checks before unfortunately :(

I'm closing this issue for now, as it seems that it is not related to our installer. However if your analysis turns out that it is related to our installer, feel free to reopen.