piwheels / packages

Issue tracker for piwheels package issues
https://github.com/piwheels/packages/issues
20 stars 5 forks source link

pylibsrtp package builds fail #184

Closed jlaine closed 3 years ago

jlaine commented 3 years ago

Package name: pylibsrtp Issue type: Missing package Link to PyPI page: https://pypi.org/project/pylibsrtp Link to piwheels page: https://www.piwheels.org/project/pylibsrtp Version: all since 0.6.1 Python version: all I am the maintainer: Yes More information:

A pylibsrtp user reported that the package doesn't seem to be getting built in https://github.com/aiortc/pylibsrtp/issues/12

Are there any logs I can look at the help resolve this?

bennuttall commented 3 years ago

Here's the output for the build attempt of the latest release on cp37m: https://paste.debian.net/1182256/

Looks like this is the important bit:

    #include <srtp2/srtp.h>
             ^~~~~~~~~~~~~~
   compilation terminated.

Is this provided by an apt package? If so, that's an easy fix

bennuttall commented 3 years ago

Would installing this package be sufficient? https://packages.debian.org/buster/libsrtp2-dev

jlaine commented 3 years ago

Hi @bennuttall ! Yes, indeed libsrtp2-dev is the only Build-Depends for this package.

What surprises me is that we had already addressed this a while back?

https://github.com/piwheels/piwheels/issues/89#issuecomment-419376084

bennuttall commented 3 years ago

I didn't add libsrtp2-dev last time - just these: https://github.com/piwheels/piwheels/commit/834c6d078d662aba0759bc5d0833d8c0b1d2dbaa

I've added it to the builders now and kicked off new builds for pylibsrtp which should come through shortly.

jlaine commented 3 years ago

Fab, seems to build just fine both for stretch and buster! Thanks so much @bennuttall