Closed ColdHeat closed 1 year ago
It it possible to apt install the requirements? Ideally we would just add something to the deploy script and rebuild this package.
Yeah I think you can apt install golang
. The version is beneath the specified required version but I don't think that actually matters. I think the code should still build and I just tried the 1.11
version of golang which apt show told me is what Raspbian provides.
Is there a way to requeue the build or would I have to push a new version?
I can install that and kick off another build. I'll try it locally first though.
Hi there, did that build work?
@bennuttall anything I can do to help out here?
@bennuttall would a PR for the deploy script help get this out?
Yes, thanks
I'll install this later and kick off another build
Thanks! Sorry I didn't mean for this to close.
The latest version built on cp37 but the rest failed. Does that sound right?
Hmm no it should build on everything. Are there any logs or anything that you can share so I can take a look? I was able to build wheels myself with Dockerfiles on a Pi3: https://github.com/ColdHeat/pybluemonday/blob/master/Dockerfile.
My only hunch would be maybe the go version matters more than I think but I can fix that.
Here you go:
0.0.4 cp37m: https://paste.debian.net/1195134/ 0.0.3 cp35m: https://paste.debian.net/1195135/
The setup.py requires >=3.6 but I can change that. Can you share the errors on the other Python versions?
EDIT: Sorry I see you only build on 3.7 and 3.5 right?
It looks like supporting 3.5 is a little trickier than it would seem. I'll try to get that supported and hopefully it won't take too long.
EDIT: Sorry I see you only build on 3.7 and 3.5 right?
We only build for Python versions in Debian - and stop when a version of Debian goes EOL (like Jessie with Python 3.4 did last year.
Python 3.5 is officially EOL as far as Python is concerned, however it is still in support in Debian, but only for another year, and usage is quite small:
So if it's nontrivial I wouldn't bother.
Yeah it's a nightmare. This should be all good afaik so thanks for all your help!
Sorry to bother one more time but I just pushed a new version and it looks like that build failed on 3.7 as well. Is there just a delay or is there an error?
They both failed
cp35m: https://paste.debian.net/1195195/ cp37m: https://paste.debian.net/1195196/
This is failing because go can’t download dependencies from GitHub? This error looks nonsensical, is it possible this is a piwheels issue? Or perhaps a transient one, could you requeue?
$ GOPATH=/tmp/tmpvfo9y2m3 go get -d 2021-04-25T22:08:37,232 package github.com/microcosm-cc/bluemonday: cannot download, https://github.com/microcosm-cc/bluemonday uses insecure protocol
Using https but still insecure?
On Mon, Apr 26, 2021 at 6:43 AM Ben Nuttall @.***> wrote:
cp35m: https://paste.debian.net/1195195/ cp37m: https://paste.debian.net/1195196/
— You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/piwheels/packages/issues/197#issuecomment-826728383, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABITPNYHVDE2PLSQFEFW5TTKU7WBANCNFSM42KSJ7IQ .
The initial failure seems to be here:
sh: 1: ./scripts/setup-arm6vl.sh: not found
Oh thanks, I didn’t notice that. That’s some code to bootstrap a go environment. I see the make calls are also failing. That could be an issue but I don’t think it explains why the installed go can’t download over HTTPS?
On Mon, Apr 26, 2021 at 10:37 AM Ben Nuttall @.***> wrote:
The initial failure seems to be here:
sh: 1: ./scripts/setup-arm6vl.sh: not found
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/piwheels/packages/issues/197#issuecomment-826887136, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABITPJKTJ4QLVJMOUSDXR3TKV3CRANCNFSM42KSJ7IQ .
I put up another release which looks like it also failed :(
Lmk if there's anything I can do to get this to build properly.
git clones are not permitted in piwheels builds. Is this a hacky workaround or is this just the way go package management works? If go-implemented packages require cloning git repositories that seems problematic for piwheels :/
I'm not completely sure but it does seem like go get runs git clone internally: https://nanxiao.gitbooks.io/golang-101-hacks/content/posts/go-get-command.html
From my research it seems like there's no way to work around the usage of git in go get.
Is there any kind of workaround here other than that? It seems like go get has a -insecure
flag that might fix the above HTTPS error. But I'm not particularly sure if that is the best approach.
Would you probably just recommend pushing the package to pypi?
Why are git cloned disabled?
Package name: pybluemonday Link to PyPI page: https://pypi.org/project/pybluemonday/ Link to piwheels page: https://www.piwheels.org/project/pybluemonday/ Version: all Python version: all I am the maintainer: Yes More information: pybluemonday is a Python binding to a Golang library so it needs golang available. I tried to do some bootstrapping in setup.py and install what's needed but it doesn't look like piwheels was able to build the wheel. Is it possible to get golang installed as a dependency or let me know what went wrong so I can debug it?
I'm testing this out on an rPI 3 now and it does work.
Building works
Wheel installs
Code runs