search

piwheels / packages

Issue tracker for piwheels package issues
https://github.com/piwheels/packages/issues
20 stars 5 forks source link

Missing package: helics #211

Open kdheepak opened 3 years ago

kdheepak commented 3 years ago

Package name: helics Link to PyPI page: https://pypi.org/project/helics Link to piwheels page: https://www.piwheels.org/project/helics/#install Version: e.g. v2.7.0.post5 and below Python version: all I am the maintainer: Yes

Is there a build log that I can view somewhere? I don't have a raspberry pi on hand to test this at the moment.

bennuttall commented 3 years ago

Here's the build output for 2.7.0.post8 on cp37m: http://paste.debian.net/1199300/

kdheepak commented 3 years ago

Thanks for sharing the build log. I fixed one of the issues. Can you share the log for v2.7.0.post9?

bennuttall commented 3 years ago

http://paste.debian.net/1199724/

kdheepak commented 3 years ago 
2021-06-01T17:25:35,259   [ 22%] Performing download step (git clone) for 'libzmq-populate'
2021-06-01T17:25:35,259   Cloning into 'libzmq-src'...
2021-06-01T17:25:35,259   fatal: transport 'https' not allowed
2021-06-01T17:25:35,260   Cloning into 'libzmq-src'...
2021-06-01T17:25:35,260   fatal: transport 'https' not allowed
2021-06-01T17:25:35,260   Cloning into 'libzmq-src'...
2021-06-01T17:25:35,260   fatal: transport 'https' not allowed
2021-06-01T17:25:35,260   -- Had to git clone more than once:
2021-06-01T17:25:35,261             3 times.
2021-06-01T17:25:35,261   CMake Error at libzmq-subbuild/libzmq-populate-prefix/tmp/libzmq-populate-gitclone.cmake:31 (message):
2021-06-01T17:25:35,261     Failed to clone repository: 'https://github.com/zeromq/libzmq.git'

it looks like a git clone failed? We are doing the same thing for the helics-apps package and that passes successfully. Any idea why the clone fails here?

kdheepak commented 3 years ago

Would you be able to share the latest log for helics-apps too? Maybe that’ll hint at what might be going on here?

bennuttall commented 3 years ago

2.7.0.post0.dev7 success on cp35m: https://paste.debian.net/1199755/ 2.7.0.post1 failure on cp35m: https://paste.debian.net/1199756/

kdheepak commented 3 years ago

Do you know why https transport is not allowed?

cc @nightlark

bennuttall commented 3 years ago

git clones are not permitted actually: https://github.com/piwheels/piwheels/blob/master/piwheels/slave/builder.py#L420

kdheepak commented 3 years ago

We require zeromq as a dependency and that’s what it is trying to clone. Any suggestions for how to proceed to get this to work?

bennuttall commented 3 years ago

Which zeromq? The python library? Can't you depend on https://pypi.org/project/pyzmq/ rather than a git repo?

zmq is pre-installed on piwheels anyway btw :man_shrugging:

kdheepak commented 3 years ago

Which zeromq?

We just need zeromq the library and not the python bindings. The C++ library we are building helics links with zeromq.

In the log you shared in your first comment in this thread there are these lines from cmake: 

2021-05-28T20:20:32,518   CMake Error at CMakeLists.txt:540 (message):
2021-05-28T20:20:32,518     ZeroMQ not found, needed to enable the ZMQ Core

That's why I assumed that zeromq was not available. If zmq is pre-installed, any suggestions for how to link to it? Why is cmake not able to find it.

cc @phlptp and @nightlark, maybe you have more input on what might be going on here. This means that the helics-apps piwheel build is also failing.

bennuttall commented 3 years ago

We have libzmq5 installed: https://github.com/piwheels/piwheels/blob/master/deploy_slave.sh#L27

nightlark commented 3 years ago

It might be the use of HELICS_ZMQ_FORCE_SUBPROJECT in https://github.com/GMLC-TDC/helics-packaging/blob/master/helics_apps-pip/setup.py#L83

The trade-off is that users will need to install a compatible ZeroMQ version, unless the piwheels builder runs auditwheel and bundles the libzmq shared library into the wheel?

bennuttall commented 3 years ago

No but we use python-apt to calculate dependencies and show them on the project page: https://www.piwheels.org/project/numpy/

kdheepak commented 3 years ago

Thanks for that information @bennuttall. I removed HELICS_ZMQ_FORCE_SUBPROJECT in 2.7.0.post10. Can you share that log again? I'm not sure if there's an easier way to see what is going on than asking you for the log over and over again. If there is let me know.

bennuttall commented 3 years ago

That's the same problem: http://paste.debian.net/1200027/

I'm not sure if there's an easier way to see what is going on than asking you for the log over and over again. If there is let me know.

Not right now, but we're planning to publish the logs in future. See https://github.com/piwheels/piwheels/issues/1

kdheepak commented 3 years ago

Can you share the log for 2.7.0.post11?

kdheepak commented 3 years ago

From this file: https://github.com/piwheels/piwheels/blob/05f0819581dd44844a5e99462746a50e28f46b56/deploy_slave.sh#L42

It looks like libzmq5 is installed but I think we need libzmq3-dev to install from source. What is the recommended way to get that in the build environment? Can we run apt install libzmq3-dev in setup.py?

nightlark commented 3 years ago

libzmq5-dev should work too.

bennuttall commented 3 years ago

libzmq3-dev should work. We'd add it to deploy_slave.py and install it before trying again. I'll try and test it out over the weekend.

https://packages.debian.org/buster/libzmq3-dev

bennuttall commented 1 year ago

Build logs are available on the project page here if anyone wants to take a look: https://www.piwheels.org/project/helics

kdheepak commented 1 year ago

Pinging @nightlark or @phlptp.

It still is failing because of zmq it appears, but I don’t think I have the bandwidth to help figure this out unfortunately.

kdheepak commented 1 year ago

It’s nice that build logs are available on the page now! Thanks for maintaining this project!