piwheels / packages

Issue tracker for piwheels package issues
https://github.com/piwheels/packages/issues
20 stars 5 forks source link

Missing package: simplepyble #347

Open kdewald opened 1 year ago

kdewald commented 1 year ago

Package name

simplepyble

Package version

all

PyPI URL

https://pypi.org/project/simplepyble/

piwheels URL

https://www.piwheels.org/project/simplepyble/

Python version

I am the maintainer

More information

SimplePyBLE is a Python wrapper of SimpleBLE, which uses libfmt as a third party dependency.

According to the error described in the build log, the runner is not able to clone the corresponding libfmt repository and the build fails.

bennuttall commented 1 year ago

It's a missing package - updated title accordingly.

The problem is that the package tries to run a git clone as part of its build procedure, which we do not allow.

You'll have to raise an issue with the package maintainers and suggest that they use packaged software (apt or pypi) rather than relying on code on GitHub.

kdewald commented 1 year ago

That's good to know, thanks @bennuttall for the info.

I'm the maintainer of the package, so I do have a few questions in order to proceed:

bennuttall commented 1 year ago

I just installed libfmt-dev on one and it built successfully. I can add it to the build script and roll it out to builders and then kick off a rebuild and we should be good :+1:

bennuttall commented 1 year ago

Oh, that's me being dumb. I forgot that running pip wheel manually didn't reject git clones, so that's still a problem.

Is there a way I can recognize that I'm being built by pywheels? (That way I can redirect the build process to use system packages instead)

We now set the environment variable PIWHEELS_BUILD: https://github.com/piwheels/piwheels/pull/326/files

kdewald commented 1 year ago

Oh, that's me being dumb. I forgot that running pip wheel manually didn't reject git clones, so that's still a problem.

Is there a way I can recognize that I'm being built by pywheels? (That way I can redirect the build process to use system packages instead)

We now set the environment variable PIWHEELS_BUILD: https://github.com/piwheels/piwheels/pull/326/files

That's awesome! Let me make the changes on my end and see how it works. I'll keep you posted.

kdewald commented 1 year ago

That seems to have worked.

Buster failed to install due to missing libfmt: https://www.piwheels.org/logs/0000/0947/9153.txt

But Bullseye worked, so it seems we're almost there :D

kdewald commented 1 year ago

@bennuttall no hurry on my end, but wanted to make sure you had seen the message above :D

bennuttall commented 1 year ago

I'm not sure what the cause of the failure is. I installed libfmt-dev: https://packages.debian.org/buster/libfmt-dev