pixaline / bardmacroplayer

FFXIV Bard Macro Player
23 stars 4 forks source link

Midi input support #3

Closed pixaline closed 6 years ago

pixaline commented 6 years ago

Had a thought earlier - since the program already parses the keybinding information, and provides a way for midis for playback - why not add support for midi input devices as well? Currently, you are required to download something like Bome's Midi Translator and set it up with a specific keybind file.

Quick googling made me aware of midi4ahk, it seems relatively easy to set up and use, and would only add an (optional) dll file next to the exe.

My only problem is that i don't actually have a piano keyboard to hook up to my computer. So, i could try and implement this feature, and anyone who has a midi input device could try it out and report bugs.

pixaline commented 6 years ago

OK, added basic support midi input at 0be02d0 and 03ca199. I reworked the interface to add a selection menu and added some other stuff as well. feel free to pull and test, i tested with a basic virtual input device, so in theory, it should work fine with your piano.

Nerdorable commented 6 years ago

Hello. I'm sorry if this is not the right place to comment as I am new to this site, but I wanted to thank you for making this wonderful tool. The separation of tracks is especially useful.

I had a request regarding midi input. The test.txt contains notes/composition for a song with input parsed in a way FFXIV understands. Would it be possible for the tracks generated from midi files to be exported into similar text files that we can edit and use separately? Some midis are a bit off when it comes to their timings. If we could edit the compositions your program is generating we could make them much more accurate.

Another request I would like to add is a tempo slider to compliment the octave slider.

pixaline commented 6 years ago

@Nerdorable No this is its own issue, please create your own issue for feature requests (button in the top right corner).

I can say that the original idea of midi playback was to only let them play, but i've thought about a way to convert them in to bard arrangement files. However, there are a lot of ways to interpret midi files and combining the tracks. It could be done with a lot of experimentation but i'm a bit busy nowadays.

As for the tempo slider, that could also be done. I'll look in to it.

Delequiox commented 6 years ago

Hi Parulina.

Sorry if this isn't the correct place to post this, but I'm using your application and it runs great. No Issues. Thank you so much for your efforts.

I had a question regarding midi format compatibility. If I use a midi file from let's say MuseScore for example, it works just fine. However if I export that midi file after I've tweaked some notes in a program like AnvilStudio I get an Unknown Event error. Is there something I'm missing here on how this application reads midi files? Thanks in advance.

pixaline commented 6 years ago

You should submit an issue of that error message with the big green button on the top right.

Closing this issue.