pixel / hexedit

View and edit files in hexadecimal or in ASCII
http://rigaux.org/hexedit.html
GNU General Public License v2.0
98 stars 41 forks source link

Fix compiler warnings and off_t handling on 32 bit #36

Closed stoeckmann closed 4 years ago

stoeckmann commented 5 years ago

While investigating compiler warnings I encountered a bad DIE message which I introduced yesterday (sorry for that!) and an issue that arises when compiling hexedit with --disable-largefile on a 32 bit system.

The code assumes that off_t is always 64 bit, which is not always the case on 32 bit systems -- but almost always. In either way, hexedit works in that scenario as expected now.

The only shown warning is left in the signal handler because signo is not used. As stated in a previous message, the signal handler is a subject for its own patch.