search

pixelandtonic / garnishjs

UI toolkit by Pixel & Tonic
MIT License
39 stars 5 forks source link

Add ability to only close modals by button interactions. #7

Closed ryanpcmcquen closed 5 years ago

ryanpcmcquen commented 5 years ago

Currently, clicking outside of a modal causes it to close and erase any unsaved work. It'd be nice if this was at least configurable.

andris-sevcenko commented 5 years ago

You can already disable this behavior by setting the hideOnShadeClick setting to false.

ryanpcmcquen commented 5 years ago

@andris-sevcenko, that's not modifiable on Craft CMS though, is it?

andris-sevcenko commented 5 years ago

It's not possible to transfer issues between organizations on GitHub. Can you please open a new issue in craftcms/cms, if you were looking for a Craft setting?

ryanpcmcquen commented 5 years ago

@andris-sevcenko, thank you. I have one there with a workaround:

https://github.com/craftcms/cms/issues/4610

PR: https://github.com/craftcms/cms/pull/4611

But perhaps that PR should be changed to use the hideOnShadeClick prop you mentioned. I will rework it in the morning to use that. Thank you!