pixelant / pxa_dealers

Extension to display searchable dealers/shops or other points of interests on Google maps

GNU General Public License v2.0

0 stars 1 forks source link

Feature radiobox #34

Closed ihorko-git closed 3 years ago

ihorko-git commented 3 years ago

New Pull Request checklist

PR Type

What kind of change does this PR introduce?

[x] [FEATURE] - A new feature
[ ] [BUGFIX] - A bug fix
[ ] [TASK] - Any task, which is not a new feature or bugfix
[ ] [TEST] - Adding missing tests
[ ] [DOC] - Documentation only changes
[ ] [WIP] - Work in progress tag, should not be present when creating pull requests

Breaking change

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Description

ihorko-git commented 3 years ago

Here is only one issue, but it was present before this changes. Method FilterItem._showVisibleItemsSelectBox is written only for specific case of filtering by country. You can check it here visibleList = String(document.querySelector(_map).dataset.visibleCountries); Should I fix this?