Closed tim9413 closed 5 years ago
Hey, We need a correct commit message here: https://github.com/t3kit/t3kit/blob/master/CONTRIBUTING.md
@dmh Do you mean "[TASK] Change package name" should be "[BUGFIX] change package name"?
@tim9413 I think that's what @dmh means. In any case: It sounds like a good thing to make that change.
Hey guys @mabolek @tim9413
Sorry for the misunderstanding.
I meant PR message
not commit message
.
We need to have well formatted and understandable changelog based on 'git log', for this we need to use option 'Squash and merge' instead of just 'Merge' for merging Pull-Requests, and in case of 'Squash and merge', commit message will be consist of 'PR message' and here we have 'test9' which is wrong.
Is it too late to change the branch name and PR message?
It is not too late, but I would skip it, let it be like it is. Keep this info for future Pull-Requests.
Duly noted.
Okey
Hey, We need a correct commit message here: https://github.com/t3kit/t3kit/blob/master/CONTRIBUTING.md