pixelant / pxa_product_manager

Product Manager. Allow to create and list products on a site. Create dynamical attributes for products. Filter by categories and attributes
11 stars 14 forks source link

[TASK] code refactoring valuemappers and userfunc for solr attributevalue #367

Closed pixelmatseriks closed 2 years ago

pixelmatseriks commented 2 years ago

Update Pixelant\PxaProductManager\Attributes\ValueMapper*Mapper classes. Remove Product $product parameter since it isn't used. Also the AttributeValue model already contains a product.

Remove MapperFactory from Pixelant\PxaProductManager\UserFunction\Solr\AbstractValue. No need to use MapperFactory on the AttributeValue if one is found, "mapping" will occur in AttributeValue model if needed.

New Pull Request checklist

PR Type

What kind of change does this PR introduce?

Breaking change

Does this PR introduce a breaking change?

Description