pixelant / pxa_product_manager

Product Manager. Allow to create and list products on a site. Create dynamical attributes for products. Filter by categories and attributes

11 stars 14 forks source link

[BUGFIX] Check for that the attribute.identifier and not renderValue #402

Closed MattiasNilsson closed 1 year ago

MattiasNilsson commented 1 year ago

New Pull Request checklist

PR Type

What kind of change does this PR introduce?

[ ] [FEATURE] - A new feature
[x] [BUGFIX] - A bug fix
[ ] [TASK] - Any task, which is not a new feature or bugfix
[ ] [TEST] - Adding missing tests
[ ] [DOC] - Documentation only changes
[ ] [WIP] - Work in progress tag, should not be present when creating pull requests

Breaking change

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Description

Check for that the attribute.identifier and not renderValue. This is to prevent that values of for example type ''000'' do not get rendered at all.