Closed pixelastic closed 4 years ago
Actually set it as the default now, and norska
should be moved to dependencies
.
For websites with a subfolder ./docs
with the webite, a better approach would actually be to make the repo a lerna-managed monorepo where each folder has its own package.json
Setting
NODE_ENV
as default on Netlify should make builds faster as it will not install thedevDependencies
.norska
is listed most of the time as adevDependencies
and not adependencies
, but maybe it should move to a proper dep. Knowing if a SSG is a dev dep or a proper dep is a tough question.One issue would be for libraries that have their website in a
./docs
subfolder. Thennorska
should clearly be adevDependency
as we don't want to release it. But in that case settingNODE_ENV
to production would prevent deploying the website.Overall I feel like I shouldn't make NODE_ENV a production value by default, yet