Add percy check when releasing a new tailwind plugin

pixelastic / norska

🏔️ Custom SSG using Pug, Webpack, PostCSS and Tailwind.

https://projects.pixelastic.com/norska/

MIT License

8 stars 0 forks source link

Add percy check when releasing a new tailwind plugin #84

Closed pixelastic closed 3 years ago

pixelastic commented 4 years ago

If we update the Tailwind plugins, or update Tailwind itself, we might break the way our custom plugin renders. We have dedicated pages to tests to the output in /percy/ in the docs website. Percy should be used to check those files whenever we do a new relevant release.

[x] Whenever we do a release, check if norska-css files are changed
[x] If so, build the doc website and start a Percy check
[x] Put the release process on hold.
[x] Ask the user to confirm the Percy checks are ok
[x] Stop the release if not ok, continue if ok

To also do: make the tests simpler (no mobile testing, no Firefox testing)

pixelastic commented 4 years ago

Any change on norska-css will trigger a percy check on release. The check will wait for human validation

TODO:

~Need to trigger a documentation build before running percy build~
[ ] Need to configure Percy to not take Firefox screenshots (I could do it in the UI, but I'd like it in a config file)
~Need to configure Percy to not take mobile screenshots~
[ ] Need to configure Percy to change the base commit. The first commit took screenshots of all pages, we're now only interested in the ./percy subfolder

pixelastic commented 4 years ago

[ ] Check if CI builds are taking longer because it's downloading Pupetteer (we don't need Percy dependency on CI)
[ ] Understand how Percy can be added to Renovate PR checks

pixelastic commented 4 years ago

[x] Fix tests when releasing
[ ] Failing test is because the CSS compilation takes more than the maximum 5s. I'm not sure what I'm doing that is taking that much time, but simply loading theme files seems to add up to 3s, which is weird. I should check with https://www.npmjs.com/package/0x to see if I can understand the issue.
[ ] Release a v2 of norska. It should not break any existing website because renovate won't pick it up

pixelastic commented 4 years ago

My custom tailwind config seems to slow down the generation a lot:

Default settings
   ✅ Finished in 2.74 s
   ✅ Finished in 2.5 s
   ✅ Finished in 2.57 s
   ✅ Finished in 2.48 s
   ✅ Finished in 2.4 s
   ✅ Finished in 2.37 s
   ✅ Finished in 2.33 s
   ✅ Finished in 2.34 s
   ✅ Finished in 2.36 s
   ✅ Finished in 2.36 s
   ✅ Finished in 2.49 s
Custom settings
   ✅ Finished in 4.67 s
   ✅ Finished in 4.84 s
   ✅ Finished in 4.7 s
   ✅ Finished in 4.69 s
   ✅ Finished in 4.76 s
   ✅ Finished in 4.7 s
   ✅ Finished in 4.69 s
   ✅ Finished in 4.64 s
   ✅ Finished in 4.66 s
   ✅ Finished in 5.17 s
   ✅ Finished in 4.67 s

pixelastic commented 3 years ago

Closing this as the whole Percy thing might have been a bad idea. It does not seem to perfectly fit into a one-man release process without review. I'll close and re-open when I have a better idea of what to do.