search

pixelated / pixelated-user-agent

User facing components of Pixelated: a JavaScript single page app and a RESTful service.
GNU Affero General Public License v3.0
159 stars 72 forks source link

Ship our local version of google-chrome and chromedriver #1080

Closed tuliocasagrande closed 7 years ago

tuliocasagrande commented 7 years ago

Fix functional test step Then I should see the fancy interstitial, that's not working properly with newer versions of chromedriver.

Since the debian repo doesn't provide old versions of chromium, we're shipping our own local copies:

$ chromedriver --version
ChromeDriver 2.27.440175 (9bc1d90b8bfa4dd181fbbf769a5eb5e575574320)
$ google-chrome --version
Google Chrome 54.0.2840.100
thaissiqueira commented 7 years ago

Using the chromedriver branch I were able to run 'make tests_all' in a smoothly way. Looks good to merge for me 👍