pixelated / puppet-pixelated

Puppet Module to setup the Pixelated User Agent
GNU Affero General Public License v3.0
13 stars 4 forks source link

Remove behave_testuser from functional tests #56

Closed anikarni closed 7 years ago

anikarni commented 7 years ago

Our functional tests were dependent on a static user name "behave_testuser", which quite frequently led to inconsistencies in our pipeline. Due to delays in deleting this test user on tear down, sometimes this user had an empty key that wouldn't be deleted until a few hours later.

To avoid breaking our tests for this reason, we decided to always use a random user in our tests. These changes are for that.

thaissiqueira commented 7 years ago

Hey, @anikarni!

Fix this intermittence will help us a lot in terms of be confident with our dashboard 🎉 My only suggestion is to use 'When' instead of 'Given' at 'When I login' steps. For that, you could put a second tag on that step, like here