search

pixelated / puppet-pixelated

Puppet Module to setup the Pixelated User Agent
GNU Affero General Public License v3.0
13 stars 4 forks source link

Add auto-restart for apache configuration #57

Closed anikarni closed 7 years ago

anikarni commented 7 years ago

See: https://github.com/pixelated/project-issues/issues/412

varac commented 7 years ago

Hi @anikarni and @tuliocasagrande , this is really awesome ! From the first glance, it looks good and I'm glad to have an rspec test included!

I'd like to ask if you could do this merge req for leap_platform itself, because this is sth that would benefit both projects. And since I'm working on the leap_platform, I'll promise there will be no delay :D

https://0xacab.org/leap/platform/merge_requests

thx !

varac commented 7 years ago

And btw, a merge request for leap_platform on 0xacab.org also has the benefit that this MR will be deployed to a server from scratch and tested (while we just have the unit tests on travis atm).

varac commented 7 years ago

If you do a merge req for leap_platform, you can use the systemd resources like Exec['systemctl-daemon-reload'] or the systemd::enable define from the puppet/modules/systemd module.

tuliocasagrande commented 7 years ago

@varac I didn't follow you.

We can use these approaches instead of the /etc/systemd/system/apache2.service.d/auto_restart.conf file? Or we're going to need both?

tuliocasagrande commented 7 years ago

Moved to leap_platform: https://0xacab.org/leap/platform/merge_requests/66