search

pixelb / fslint

Linux file system lint checker/cleaner
314 stars 74 forks source link

Invert default merge behaviour? #137

Open chrisrapson opened 7 years ago

chrisrapson commented 7 years ago

Having just accidentally merged a long list of files, I wonder if you would consider inverting the default behaviour (i.e. merge UNselected files)? Or point me towards an explanation of the reasoning behind the current default?

I would think that if I wanted to batch merge, then it would be relatively easy to select all (perhaps a shortcut such as ctrl-A could be added) and then merge. Selectively merging by selecting and toggling selection is quite tricky, and the penalty for getting it wrong is heavy, as there is no undo button and even manually reverting is quite tricky because finding hardlinked files is non-trivial.

pixelb commented 7 years ago

And undo operation would be awkward but also impossible to do fully due to the metadata of the original files being deleted. The thinking is the confirmation prompts are enough protection

chrisrapson commented 7 years ago

I get your point. The prompt was enough protection for me the first ~30 merges, but then I got confirmation fatigue and messed up.

What about adding another button "merge selected", or having the behavior of the existing button be customisable via a setting? That would not only save me from my own user error, it would save me time by not having to right-click, toggle-selection for each set of duplicates.

pixelb commented 7 years ago

I suppose the buttons on the merge dialog could change from: yes/no to selected/unselected/cancel