search

pixelb / fslint

Linux file system lint checker/cleaner
314 stars 74 forks source link

2020 is knocking on the door #140

Closed MaxValue closed 6 years ago

MaxValue commented 6 years ago

Hi! I just installed fslint (2.44-2ubuntu1) on Ubuntu (17.10 64bit Server). Unfortunately it doesn't start through the desktop link.

I ran the fslint-gui command directly and this popped up:

  File "/usr/bin/fslint-gui", line 182
    except getopt.error, msg:
                       ^
SyntaxError: invalid syntax

I then dawned me that this software is using python2 and according to the Python documentation this is outdated syntax (even for python2). I know it should be supported by python, but apparently it isn't. I tried it several times, i dunno why it doesn't work. My version (/usr/bin/env python2):

Python 2.7.14 (default, Sep 23 2017, 22:06:14) 
[GCC 7.2.0] on linux2

I know my fslint version isn't the newest (2.46), but this is still in the latest code: except getopt.error, msg:

A solution is to fix this by making it except getopt.error as msg:, but a more future proof solution would be to start converting to python3 (no more interpreter updates for python2 in 28 months!). How 'bout it?