search

pixelcog / gmail-to-pdf

A Google Apps Script library for converting Gmail messages to PDFs for easy archival.
http://bit.ly/1CsBl8U
123 stars 38 forks source link

GAS V8 Runtime updates #15

Open lex3001 opened 4 years ago

lex3001 commented 4 years ago

I made two changes so that this works with the new Google Apps Script V8 Runtime. It should still work with the old version too, but I am not 100% sure about that. 1) change the check that uses "class" as an identifier ... GAS V8 does not appreciate that use of "class" 2) update the code that determines the current time zone to put into the email PDF, the regular expression doesn't work in V8 because the long name of the time zone is returned instead of the abbreviated version; updated the code to use another method

frankyw commented 4 years ago

Can we get this merged?

emmanueljarri commented 3 years ago

Hello, I confirm the current code doesn't work for me, but with modifications from @lex3001 it now works !

Can you please merge this fix in your repo which is the master please?

Thank you !

frankyw commented 3 years ago

@emmanueljarri I gave up on these guys a long time ago, seems like this project is abandoned sadly.

You are welcome to use my updated library with ID: 1CdCFwL5USI7KRfuVfoOWXJUCo4kGTL05fRwDPmpJVzETix09Nuy_v8bK