search

pixelcog / parallax.js

Simple parallax scrolling effect inspired by Spotify.com implemented as a jQuery plugin
MIT License
3.53k stars 840 forks source link

This line broke parallax when some title or other element is inside as well. #279

Open rzymianin11 opened 5 years ago

rzymianin11 commented 5 years ago

https://github.com/pixelcog/parallax.js/blob/49e44cd2308ada661c1653387407217f1437fbb8/dist/jquery.parallax.js#L880

This line broke parallax when some title or other element is inside as well.

Should be: if ($s.children('img').each(function () {

Anyway I think the best is find only one image or with some class, like: "background for parallax"