pixelfed / pixelfed-rn

Pixelfed mobile app
https://pixelfed.org/mobile-apps
GNU Affero General Public License v3.0
154 stars 7 forks source link

Add to F-Droid #79

Open licaon-kter opened 3 months ago

licaon-kter commented 3 months ago

Once proprietary dependencies are removed or separated in a gradle flavor and the app is FOSS.

Refs:

https://github.com/pixelfed/pixelfed-rn/blob/b9d30ab5baf77bf39513ebe34dc15960292e1fc3/package.json#L69 -> https://github.com/expo/expo/blob/df7e40ba264a2c452cd944b19376c5dc1b7d9a9d/packages/expo-application/android/build.gradle#L22

https://github.com/pixelfed/pixelfed-rn/blob/b9d30ab5baf77bf39513ebe34dc15960292e1fc3/package.json#L63 -> https://github.com/TheWidlarzGroup/react-native-video/blob/v6.2.0/android/build.gradle#L218 (can be excluded afaik)

https://github.com/pixelfed/pixelfed-rn/blob/b9d30ab5baf77bf39513ebe34dc15960292e1fc3/package.json#L64 -> https://github.com/mrousavy/react-native-vision-camera/blob/v4.3.2/package/android/build.gradle#L202

etc

poVoq commented 3 months ago

Could you explain better what you mean, please ? All of the three examples you mentioned above claim to be MIT licensed.

Edit: Ah, you mean indirect dependency on google play service? At least the first one seems to be only a fallback.

licaon-kter commented 3 months ago

You follow the links and they point to proprietary Google libs, those are dependencies for the app.

While the first two might seem easier to exclude, the third one, mlkit, might be impossible (from experience), also this being a photo app, might not be feaseble to publish it without... a way to take photos. :) :(

poVoq commented 3 months ago

How does Pixeldroid do the last one, since it is already on F-Droid?

licaon-kter commented 3 months ago

This is a React Native app using React Native libs (and they own deps are the tricky ones here), the availability of libs for different tasks for different languages/frameworks varies.

Pixeldroid is a Java app using AndroidX camera libs, that are FOSS.

licaon-kter commented 3 months ago

Do add a Fastlane folder structure for icon/pics/changelog/description/etc: https://gitlab.com/-/snippets/1895688

licaon-kter commented 3 months ago

Also start tagging releases ;)