ZipZap causes some static analyzer warnings

pixelglow / ZipZap

zip file I/O library for iOS, macOS and tvOS

BSD 2-Clause "Simplified" License

1.22k stars 199 forks source link

ZipZap causes some static analyzer warnings #150

Closed rsanchezsaez closed 7 years ago

rsanchezsaez commented 8 years ago

If you run Xcode 8 Static Analyzer on ZipZap, some warnings result. Particularly, some properties and methods which are annotated as nonnil, are returning nil:

Some ideas:

If the methods returning nil are part of an abstract class and are never supposed to be called, this can be resolved by adding NSAssert(...) before returning nil.
As for the properties, these shouldn't be set to nil, or they should be annotated as nullable.

Thanks!

pixelglow commented 8 years ago

I'll take a look, it may take a while for me to fix since I'm the middle of transitioning from Xcode 7 to 8.

Feel free to submit a pull request to fix these errors. In particular, ZZArchiveEntry is an abstract class but ZZArchive and ZZInflateInputStream are not.