pixelglow / ZipZap

zip file I/O library for iOS, macOS and tvOS
BSD 2-Clause "Simplified" License
1.22k stars 199 forks source link

Address compression related memory handling. #164

Open levigroker opened 7 years ago

levigroker commented 7 years ago

Specifically:

open now checks the stream status before potentially opening again (and leaking memory).

close now checks stream status before attempting to close (potentially closing an already closed stream). Also an autoreleasepool now wraps the NSData object creation. Since close may be called in tight loops, this correctly releases memory in a timely manner.

write:maxLength: now is wrapped in an autoreleasepool. Since this is called in tight loops, the creation of the outputBuffer was causing memory to grow as a compresion was underway. The autoreleasepool mitigates this situation.