search

pixelgrade / anima

Anima is the universal FSE WordPress theme of Pixelgrade.
GNU General Public License v2.0
6 stars 1 forks source link

Extra menu fields dissapear when I visit the Appearance - Menus #213

Open andreiungurianu opened 3 years ago

andreiungurianu commented 3 years ago

While using the current version of Rosa2 (v.1.8.1) I noticed some problems with displaying the extra fields (Descriptions, Badges) for menu items.

When navigate to Appearance -> Customize -> Menus right after I install a fresh version of Rosa2, I can see all the available extra fields for the menus. But I think some of those fields should be hidden (like Title Attribute and such).

Now, if I navigate to Appearance -> Menus and do nothing there (just load this section), when I go back to the Customizer, these extra fields are not available anymore. Only the Badge field shows up.

https://user-images.githubusercontent.com/53944294/106148717-0efc7180-6182-11eb-8512-1257ab27cfb9.mov

The same goes when I update the theme from an earlier version. If I navigate to Appearance -> Customize -> Menus, the Description field is not enabled by default.

From my understading, we should have the Badge and Description fields enabled when people update or install the theme.

@georgeolaru - please correct me if I'm wrong.

madalingorbanescu commented 3 years ago

I have tried to replicate this behavior on a fresh installation of WordPress with the default theme, and it's the same, so we are not doing anything wrong.

Probably, those options (like Title Attribute and such) are registered after the first-time users enter the menus section.

andreiungurianu commented 3 years ago

Thanks for investigating @madalingorbanescu. I guess there's nothing we can do so we can close this issue or do you have any proposal on what to do next?

madalingorbanescu commented 3 years ago

The Badge field is already shown by default because this field is created by us. However, the description is coming from WordPress and by default is being unchecked in Screen Options.

The only improvement that we can do is to make sure that the Description Field is enabled by default.

@vladolaru do you think it will be ok if we'll do that?