pixelgrade / anima

Anima is the universal FSE WordPress theme of Pixelgrade.
GNU General Public License v2.0
6 stars 1 forks source link

Reverted order for the site menu on mobile #245

Closed alinclamba closed 3 years ago

alinclamba commented 3 years ago

A customer recently noticed that the order of the site menus is different on desktop vs. mobile. On desktop, Menu 1 is displayed first, on the left, and Menu 2 is placed secondly, at the right, which is correct. On mobile, instead, the first one is Menu2, and then comes Menu1.

Is there a reason we did that, or it's just something we need to fix?

Thank you.


Suppport Ticket

georgeolaru commented 3 years ago

@alinclamba Thanks for bringing this forward!

We should look into the menus from their order of relevance. Thus, the Primary menu location should appear higher in the hierarchy, no matter the device or the layout composition. (this usually means it will be on top on a single-column mobile layout).

Note that with the new Header system, the layout can have many types of compositions, but we aim to keep the concept of "Primary" menu.

Now, there seems to be a problem with our demo and the starter content, where we put the Secondary menu on the left side, which we intended to be the Primary one. An easy fix for the customers would be to re-order the blocks from the Header and reassign the menus. I did this already for our demo and seem to work well:

Screenshot 2021-04-19 at 12-08

@madalingorbanescu In the case of a single-row header with two menus (left/right) and a logo in the center, do you think we can set by default (for new users) to have the Primary menu block on the left side? Are there any implications that you see and could conflict with this intention?

madalingorbanescu commented 3 years ago

Hey @georgeolaru,

Thank you for updating the order of the block on our demo, by doing that, all users were already getting the correct order. Now, I have also updated the order for the single-row header, so when the user will add a new header block, it will use the correct order.