pixelgrade / anima

Anima is the universal FSE WordPress theme of Pixelgrade.
GNU General Public License v2.0
6 stars 1 forks source link

Improving how we handle Columns block #262

Closed andreiungurianu closed 3 years ago

andreiungurianu commented 3 years ago

**Issue 1: Columns spacing missing**

A customer of ours (deceramicastudio.com) uses Rosa2 to present the collections of work she's done in the past. This is the page where she showcases those collections.

To do that, she uses the Columns block (with 3 columns) and the Hero of the Galaxy block inside each column. As you can see from her website, there's no spacing between the columns.

The issues is that there seems to be some inconsistency in the way the columns load depending on the type of block added inside each column.

Particularly, if I add the default Cover block, there's a space between each column, as shown below: CleanShot 2021-06-10 at 12 19 34

But if I add the Hero of the Galaxy block, the columns don't have spacing between them anymore. CleanShot 2021-06-10 at 12 20 08

I've compared this to the default behaviour from Tw-Tw-One and over there it seems like they handle the columns in a consistent manner no matter the type of blocks added within each column. Below is an example:

CleanShot 2021-06-09 at 16 28 41

As I discussed with @madalingorbanescu, people most likely expect a similar behaviour no matter the WordPress theme they use.

On top of this, if we were to check other areas of the website (for example, if we open a collection) we would find that other blocks that look like columns have a spacing between the them. Here's an example with a list of products showcase on one page.

CleanShot 2021-06-10 at 12 29 10

Issue 2: There seems to be a problem with the way we handle "Wide width" for columns. Specifically, if I have the Hero of the Galaxy block within a column and use the Wide width setting, the columns look like they are "Full width". CleanShot 2021-06-10 at 12 26 28

madalingorbanescu commented 3 years ago

Closed in 49a26387494aba5c201c2ab58807d9f20800e473