pixelgrade / anima

Anima is the universal FSE WordPress theme of Pixelgrade.
GNU General Public License v2.0
6 stars 1 forks source link

Add Super Display font control and fix styling for all font size levels #283

Closed razwan closed 3 years ago

razwan commented 3 years ago

The default font-size picker in the WordPress block editor is disabled in Rosa2

The current font-size picker is added in Nova Blocks to a specific set of blocks. It works in the same way styles do... meaning that the Additional CSS class(es) field is update automatically when the font size picker changes.

We could do this though block support API, and even hide the classes from the user, but I feel it isn't necessary as I can't see any major drawbacks for the moment.

razwan commented 3 years ago

The configuration for the Super Display in the Style Manager integration and SCSS config should probably be tailored a little bit. Do you mind taking care of that, @georgeolaru ?

georgeolaru commented 3 years ago

@razwan Awesome! Thanks for working on this. I set up the default for the Super Display field and did various tests, and all seem well.

For reference, here is a page with some sample content: https://demos.pixelgrade.com/tosca/style-guide-type-scale/ ( it's useful to compare with the current version too):

Screenshot 2021-07-19 at 15-53


Few things that I noticed: