Closed razwan closed 3 years ago
The configuration for the Super Display
in the Style Manager integration and SCSS config should probably be tailored a little bit. Do you mind taking care of that, @georgeolaru ?
@razwan Awesome! Thanks for working on this. I set up the default for the Super Display
field and did various tests, and all seem well.
For reference, here is a page with some sample content: https://demos.pixelgrade.com/tosca/style-guide-type-scale/ ( it's useful to compare with the current version too):
Super Display
is not loading the font from the palette Headline
block doesn't seem to use the same logic as the regular Heading
block (screenshot)Display
and Super Display
to the Color customizations section so they can be changed independently of the Heading 1[x] While all the font styles
(e.g. size, text-transform, letter-spacing) are transferred to all variations with the font size
changes, the colors
applied to Headings do not transfer to the variation too (screenshot)
https://user-images.githubusercontent.com/1632775/126163032-d7ab24c7-3bac-4812-b9ff-92662ff002a7.mp4
The default font-size picker in the WordPress block editor is disabled in Rosa2
The current font-size picker is added in Nova Blocks to a specific set of blocks. It works in the same way styles do... meaning that the
Additional CSS class(es)
field is update automatically when the font size picker changes.We could do this though block support API, and even hide the classes from the user, but I feel it isn't necessary as I can't see any major drawbacks for the moment.