pixelgrade / customify

Intuitive Website Styling integrated into WordPress' Customizer
GNU General Public License v2.0
28 stars 5 forks source link

Enhance the Dark Mode toggle to take into account device settings #230

Closed razwan closed 3 years ago

razwan commented 3 years ago

Quoting @georgeolaru from an issue opened on Rosa2:

I think we should transform the "Dark Mode" functionality from the Customizer to an "Appearance" radio group with three options: Light (default), Dark, and Auto ( with the following description "Set light or dark mode automatically, according to the system-wide setting").

image

Regarding the switcher from the navigation, there are a few use cases, depending on the "Appearance" option:

  1. When the "Appearance" option is set to "Light" or "Dark", the switcher will take those options as a default. When pressed it will change to the other one.
  2. When the "Appearance" option is set to "Auto", the switcher will use the system option to reflect the current state (Dark or Light). When the user uses this switcher for the first time, it will override the "Auto" mode and the user will be able to manually commute between those two states.

I hope it makes more sense now.


As a side note, we could use the macOS setting as a reference (User Guide)

image

georgeolaru commented 3 years ago

@madalingorbanescu I have a few things that I noticed while testing. Have a look and let me know if you can replicate:

And two things that we can improve: