pixelgrade / gridable

The Missing WordPress Grid Content Editor
GNU General Public License v3.0
9 stars 2 forks source link

Shortcodes not rendering due to outdated Classic Editor plugin #104

Closed georgeolaru closed 4 years ago

georgeolaru commented 4 years ago

I noticed that the [row] and [col] shortcodes are not rendered in the Visual editor and there are two cases where this cause various issues:

  1. When the content is imported it comes as shortcodes which are not rendered in the Visual Editor but are looking good in the frontend. See #103 and #99
  2. When a new Row is inserted in the Visual Editor, it comes as raw HTML code. This seems to work well in the Visual Editor, but it's not looking well in frontend because no actual shortcodes are rendered, only the same raw HTML code from the editor. See #102 and #100

image

I guessed it's something related to Gutenberg and the Classic Editor—using WP-CLI I rolled back a few versions of WordPress using wp core update --version=5.x --force. I had no luck until I rolled back to version 4.9, just before the new editor was released. At that point, everything seems to work as intended.

Digging further, I looked in Pixelgrade Care over the system that disables the Gutenberg Editor and found that there are a few updates for the Classic Editor plugin. Once I've installed and activated this plugin, the Gridable is working as intended. 🎉


@alinclamba @Alexandru-Teodorescu @andreiungurianu The installation of the Classic Editor plugin is the temporary solution for clients of Rosa1 and WordPress 5.0+.

In the meantime I added an issue for @vladolaru on Pixelgrade Care, to update the functions that restore the classic editor. Once he figures out a solution, we will close all this issue and the ones mentioned above.

vladolaru commented 4 years ago

We can close this one @georgeolaru

georgeolaru commented 4 years ago

@vladolaru Great! Thanks

andreiungurianu commented 4 years ago

@vladolaru thanks for the fixes. I've updated the Pixelgrade Care plugin to the latest version(v.1.7.12) but I still find the same issues. Was this fix included in the update?

Below is a video that shows how the editing works in Rosa 1 just with the Pixelgrade Care plugin activated and how it works when I also activate the Classic Editor:

PixCare and Classic Editor differences.mp4.zip

alinclamba commented 4 years ago

@andreiungurianu I'm following this issue and I noticed your comment. From my tests, it seems it's not working for content added previously. It works only for content added after updating the Pixelgrade Care plugin.

However, I'm not that sure, but @vladolaru can tell us. 👀

andreiungurianu commented 4 years ago

Thanks for letting me know, @alinclamba. From my tests, what happens when you add a new row in a new page is the same as before the update - meaning that you can see the rows (not just shortcodes), but not the options for adding a new column, or changing the column style. This is the same behaviour as before the new update.

Here's how adding a new row works without the Classic editor and how new options show up once I activate it: Adding new rows with and without Classic editor.mp4.zip

Plus, activating the Classic Editor plugin fixes the issues for the existing content as well as for newly added one.

vladolaru commented 4 years ago

Thanks @andreiungurianu and @alinclamba for pitching in. I've digged deeper and the issue lies in Gridable since it needs to hook later in the admin area to allow for the theme-dependent logic in Pixelgrade Care to run its course.

I will update Gridable. Pixelgrade Care is fine as it is with the last update (1.7.12).

andreiungurianu commented 4 years ago

Awesome @vladolaru. It's nice to have you back 🤗

vladolaru commented 4 years ago

Thanks @andreiungurianu