Review issues

[cristianfrumusanu]

functions.php

• [x] L85 - remove theme support for search-form, you have a custom searchform.php, comment-form, you have a custom form in comments.php
• [x] L161 - use get_stylesheet_uri()
• [x] Remove the components folder, it's empty - n-am gasit folderul components (?!)

inc\customizer.php

• [x] L144-146 - use the HTML entities instead
• [ ] Upgrade to Noah Pro... - Remove the JS appended upsell in the Customizer header, it's not allowed.
• [ ] ^ you will not need assets\js\customizer.js anymore ^.

inc\extras.php

• [x] L293 - use the correct prefix for this action the_noahlite_gallery
• [x] also in template-parts\project\content-single-jetpack-portfolio.php:L42
• [x] L643 - replace with return is_admin() ? $length : 35;

inc\template-tags.php

• [x] L506 - escape $link['title']

comments.php

• [x] you're using the placeholder attribute in multiple places with the wrong escaping function esc_html__() should be esc_attr__()

searchform.php

• [x] L14,17 - you can use _ex() instead of echo

readme.txt

• [x] the license information for images used in your theme must be in this format: Bundled header image, Copyright Alvin Engler License: CC0 1.0 Universal (CC0 1.0) Source: https://unsplash.com/@englr?photo=bIhpiQA009k

• [x] also, please provide license information for all the js files even if some of them are owned by you.

• [x] the Theme URL needs to provide information about the free version, not the pro upsell. There is no info about the free version on that page.

[cristianfrumusanu]

@vladolaru Am rezolvat tot ce am bifat mai sus.

Cateva mentiuni:

• n-am gasit folderul components;
• asta am facut https://github.com/pixelgrade/noah-lite/commit/a4b7362fa01f8a55797dfc8a266825cbfe9d028c#diff-eb299bdc934d7bcc4d3c4b9c85c0e867R293 , https://github.com/pixelgrade/noah-lite/commit/a4b7362fa01f8a55797dfc8a266825cbfe9d028c#diff-99d10248967988ca3c181deba4a1b8a1R42 legat de use the correct prefix for this action the_noahlite_gallery - e ok?

Au mai ramas chestiunile legate de licentieri si Upsells.

[vladolaru]

Am facut eu restul @cristianfrumusanu. Aia cu upsell o las deocamdata si il intreb.