pixelgrade / nova-blocks

A collection of design-driven WordPress editor blocks committed to making your site shine like a newborn star 💫
https://pixelgrade.com/plugins/nova-blocks/
GNU General Public License v3.0
65 stars 4 forks source link

DuotoneFilter Breaks in WordPress 6.5 Due to Unstable Context Usage #445

Closed georgeolaru closed 6 months ago

georgeolaru commented 6 months ago

The DuotoneFilter component crashes in WordPress 6.5. This issue might stem from the use of an unstable API BlockList.__unstableElementContext within the component, located in packages/block-editor/src/filters/with-overlay-filter/with-overlay-filter-controls.js.

Given the removal of Reakit and other internal changes in WordPress 6.5, this unstable context may no longer be behaving as expected, leading to component failures. The issue might be related to the recent changes in the underlying Composite component implementation as detailed in the WordPress Core blog.

Steps to Reproduce

  1. Upgrade WordPress to version 6.5.
  2. Navigate to a block (eg. Cards Collection) that is using the DuotoneFilter.
  3. Observe that the block does not render and "This block has encountered an error and cannot be previewed." message appears

We could take into consideration disabling the Duotone feature upon finding a solution to integrate it with the changes from WordPress 6.5