pixelit-project / PixelIt

PixelIt is an ESP8266/ESP32 and WS2812B LED Matrix based PixelArt display
https://pixelit-project.github.io
MIT License
334 stars 52 forks source link

FEATURE REQUEST: Ulanzi Pixel Clock Support #259

Closed aptonline closed 1 year ago

aptonline commented 1 year ago

Flagging this here as a general feature request after starting a post in discussions and also within Discord.

https://github.com/pixelit-project/PixelIt/discussions/258

aptonline commented 1 year ago

While we wait for official support, I’ve forked the project so that fixes can be applied specific to Ulanzi, namely removal of the constant tone the Ulanzi emits when powered on using the stock PixelIt firmware.

Other fixes are also being applied but likely no major features will be implemented.

https://github.com/aptonline/PixelIt_Ulanzi

jekader commented 1 year ago

Using the PixelIt_Ulanzi fork for about a month already with no issues and I expect more people to try flashing their devices with alternative firmware. It would be great to have the changes merged upstream and get binary downloads for users who are not comfortable with installing Platformio and building firmware by themselves.

dennisse commented 1 year ago

@aptonline: Are you preparing a pull-request? :)

aptonline commented 1 year ago

I think that might be the next logical step, is the PixelIt project still being actively developed?

foorschtbar commented 1 year ago

I think that might be the next logical step, is the PixelIt project still being actively developed?

Yes, but its a community project and without input and developers, no new features will come. All must-haves are implemented. Feel free to add new ideas or PRs.

I would be happy if we merge the Ulanzi fork here, but i don't have time to do that

jekader commented 1 year ago

Had a quick look at the diff from the Ulanzi fork. It seems to overwrite existing platforms instead of adding a new one: https://github.com/pixelit-project/PixelIt/compare/main...aptonline:PixelIt_Ulanzi:main

In order to merge it in, the customizations need to be defined as a separate platform such as:

[env:ulanzi_tc001]
 platform = espressif32
 board = esp32dev

Pin definitions and other tweaks related to this device like the battery monitor need to be parametrized to keep existing functionality intact. @aptonline would you be interested in preparing these changes for merging in? Otherwise I can try doing this when I have some spare time.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

foorschtbar commented 1 year ago

@aptonline & @wsbtak thanks for your work on the Ulanzi fork. Any plans to merge it back to PixelIt main repo?

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days