Fix crashes caused by uninitialized beginCalled

pixelmatix / GifDecoder

MIT License

23 stars 9 forks source link

Fix crashes caused by uninitialized beginCalled #11

Open rbergen opened 10 months ago

rbergen commented 10 months ago

This initializes GifDecoder::beginCalled to false, to prevent storeProhibited panics that can occur further down the line due to the call to AnimatedGIF::begin() not taking place.

A discussion of the crashes caused by the bug this PR fixes can be found from this comment on https://github.com/PlummersSoftwareLLC/NightDriverStrip/issues/547 onwards, as well as the PRs that the comments in that discussion link to.

robertlipe commented 10 months ago

I'm not sure why it doesn't show, but the comment at https://github.com/pixelmatix/GifDecoder/commit/17f5678bcc637d8a66c4797a9d3244e9782b0e42#commitcomment-133982736 may be useful to a reviewer.