search

pixelmatix / SmartMatrix

SmartMatrix Library for Teensy 3, Teensy 4, and ESP32
http://docs.pixelmatix.com/SmartMatrix
621 stars 162 forks source link

Fix unexplained 10 char limit in drawString #64

Closed marcmerlin closed 5 years ago

marcmerlin commented 5 years ago

Fix https://github.com/pixelmatix/SmartMatrix/issues/57 I can't find a good reason to limit the draw size. If it runs out of the screen, it'll draw off screen without consequences I can think about.

marcmerlin commented 5 years ago

My apologies, I failed to make another branch, so other example code I was going to submit to you separately got merged in there, sorry. Are you ok merging it all, or can you merge https://github.com/pixelmatix/SmartMatrix/pull/64/commits/473afbfae534d769f5f7296231d75c9cdc24ef60 only, or you can easily copy the fixed file from master to teensylc and reject this PR.

embedded-creations commented 5 years ago

Funny, I was rushing to catch up after coming back from my trip, and thought I already had merged this PR. As it's more complicated now I'll have to put it into the queue of other SmartMatrix work.

marcmerlin commented 5 years ago

you did merge it in master, but I sumitted it for teensylc too since both branches have the same issue.

marcmerlin commented 5 years ago

I cleaned/reset my tree and made a new PR https://github.com/pixelmatix/SmartMatrix/pull/73