Comment out unused code to squelsh compilation warnings

pixelmatix / SmartMatrix

SmartMatrix Library for Teensy 3, Teensy 4, and ESP32

http://docs.pixelmatix.com/SmartMatrix

611 stars 161 forks source link

Comment out unused code to squelsh compilation warnings #67

Closed marcmerlin closed 5 years ago

marcmerlin commented 5 years ago

/home/merlin/Arduino/libraries/SmartMatrix_me/src/SmartMatrixMultiplexedCalcEsp32_Impl.h:398:7: warning: unused variable 'o0' [-Wunused-variable] } o0;

marcmerlin commented 5 years ago

If you set compiler warnings to all in your arduino config, you'll see those. I like them on so that I can catch stupid mistakes.

marcmerlin commented 5 years ago

fair small fixup patch to add?

embedded-creations commented 5 years ago

I'm in Hawaii at the moment, so my attention's not really on this. If that code truly isn't necessary (for all users, not just you), it would be better just to delete the code. I took a quick look and it seems that way, but I'm not 100% sure.

marcmerlin commented 5 years ago

replaced by https://github.com/pixelmatix/SmartMatrix/pull/75