consider renaming teensylc branch?

pixelmatix / SmartMatrix

SmartMatrix Library for Teensy 3, Teensy 4, and ESP32

http://docs.pixelmatix.com/SmartMatrix

611 stars 161 forks source link

consider renaming teensylc branch? #70

Closed marcmerlin closed 3 years ago

marcmerlin commented 5 years ago

Given what the branch is today, maybe rename it smartmatrixng ? It's not very obvious to use a teensylc branch for esp32, especially if the branch doesn't work on teensylc (not sure about that part)

embedded-creations commented 5 years ago

Good idea, but what about all the links that are already pointing at the GitHub /teensylc branch?

Thoughts:

branch (not rename branch) from teensylc and name it esp32 or whatever, make final commit to delete the contents of the teensylc branch except for a simple README.md saying "use the new esp32 branch"

marcmerlin commented 5 years ago

Your suggestion is much better

rorosaurus commented 4 years ago

That makes sense to me. Piggybacking off this, is there a reason why we want to keep ESP32 compatibility out of master branch? Can we enumerate the work that is needed?

embedded-creations commented 4 years ago

is there a reason why we want to keep ESP32 compatibility out of master branch?

That branch is a huge refactoring of the code, not just for adding ESP32 support but the Teensy code is majorly refactored. It's only alpha quality, and some things are known to be broken, other issues haven't been exposed yet because of not enough testing.

Can we enumerate the work that is needed?

There's quite a bit of work listed in the README