pixelmatix / SmartMatrix

SmartMatrix Library for Teensy 3, Teensy 4, and ESP32
http://docs.pixelmatix.com/SmartMatrix
611 stars 161 forks source link

Fm6126A test support #79

Closed marcmerlin closed 4 years ago

marcmerlin commented 5 years ago

This is not fully working, but close. Obviously, it's in the wrong place, it should be in the library and independent of the chip and pins, but as a proof of concept, it's better than nothing

marcmerlin commented 5 years ago

related to https://community.pixelmatix.com/t/smartmatrix-doesnt-support-fm6126a-driver-chips/421

marcmerlin commented 5 years ago

Are you ok submitting this in the meantime until there is a better version? I realize this is not optimal, but beats nothing? Still easy to remove once it's integrated in the lib in some way.

embedded-creations commented 4 years ago

The main reason I haven't accepted this is the GPIO pins are hardcoded, when they should rely on pinouts in the library.

Minor issues:

embedded-creations commented 4 years ago

When I was testing FM6126A support with the new board I'm working on, I made a start on some of these changes:

https://github.com/pixelmatix/SmartMatrix/commit/a7f9b79c292b35bde0df969ad82ddf19a1108334

marcmerlin commented 4 years ago

Hi louis, I agree that the code using hardcoded pins isn't ideal, I just ported it as is for testing, but obviously it's not supposed to be a long term solution. Feel free to either merge it as is under Linus "a bad driver is better than no driver" moto, or replace it with your own better one. This was meant to be a stopgap and I envisioned it would get deleted some time after being merged (with no hard feelings from me :) ) Maxled I think it used for how wide the reset sequence will be sent (important for chained panels), but that's just my guess (I didn't write the code logic). As for the array question, I don't know any more than you.

marcmerlin commented 4 years ago

obsolete